Today with fresh mind I had to change the Splash.cpp second include line from
#include "tides/generator.h"
to
#include "../eurorack/tides/generator.h"
to get Splash to compile. All else went smooth, so finally have it rebuilt for Rack 2.git.5c47e6e0. Might want to adapt that fix, perhaps, However not sure why it fails here and not for everyone else…
I still need to add the new API functionality but I think I’ve caught all of the major post-upgrade issues so it should be relatively stable and fully functional.
You don’t have to do that as the Makefile has flags that include the firmware source at compile time.
Sounds like you should delete your entire local repo and start again from scratch.
Remember to add the submodule with git submodule update --init --recursive before doing make dist
been there, done that 3 times in a row until I went to scr/Splash.cpp and it staded a path local to src that simply isn’t there as it is one up, then into the eyurorack/tides dir. Fixed, done, dusted, builds like a dream. And runs perfectly, no further action needed until ABI declared stable. So much more comfy in *nix envs , windows is foreign territory for dev/building/debugging…
I’ve patched my plugins for v2. (two commercial, one open source) but not sure when to release them because they will probably no longer work on v1. I assume that the library page only supports one major version so when should I be submitting these?
That Q sounds worthy of its own post. I remember when we went from 0.6 to 1.0 I had similar questions. btw, if you want anyone to try out your port you could provide a link to your github. I may be ignorant, but I don’t know who “elmoodio” is.
Just a suggestion - maybe make a note on your repo readme saying this is all bleeding edge stuff with no guarantees and please let the developers know if you find any issues.