Experiencing weird rearrangement issues with modules in patch

Eurikon · April 12, 2022, 10:06pm

If you have the “neat & tidy looking patch - OCD thing” like me,
opening your patch to see it all scrambled is somewhat like this:

Oh well ok… it might not be that dramatic

DaveVenom · April 12, 2022, 10:46pm

Oh, but it would be exactly like that if I saw my patch do that!

fractalgee · April 13, 2022, 7:23pm

trust me, my reaction was much more severe than yours, as I couldn’t quite work out how it had been until opening a previous version in 2.0.6 which luckily loaded fine (and all have since), but any attempt to go 2.1.0 results in same serious reaction of pulling mostly non-existing hair out

k-chaffin · April 13, 2022, 7:25pm

Is this limited to a particular OS platform?

fractalgee · April 13, 2022, 7:26pm

not sure what @Eurikon is using, mine is MacOS 12.3.1

Eurikon · April 14, 2022, 7:38am

Mac OS 12.3.1 (M1)

fractalgee · April 14, 2022, 7:41am

OK, that confirms it appears a Mac only issue. Kicker is that I had Rack2 2.1.0 running mostly fine under 12.3.1 since the day the update dropped. The only thing I updated since then and between things working fine and not fine was XCode latest and it’s updated commandline tools. That should have exactly zero impact on things…

pgatt · April 17, 2022, 7:31am

Hi all, trying to track this one down. Can anyone share a patch file where this issue has occurred with me?

fractalgee · April 17, 2022, 10:40am

FG_R2_58_11_GranularNoisePlethoraResonatorGranular_Fun.vcv (21.6 KB)

This patch needs the Southpole plugins. It tends to crash on Start of Rack2 if it’s in autosave, but it always opens fine if I tell Rack2 on next start not to clear patch but load the one that crashed anyhow. Never fails and works fine.

I know this one opens fine in 2.0.6 in it’s 4 rows, but 2.1.0 makes a 3 row jumbled mess out of it, Never saved that mess so don’t have one lying about that shows issue and failed to take a screenshot. Sorry, but can’t update to 2.1.0 again as it drives me up the wall in a few seconds… Looks like you need an M1 original machine (Mini or MBP) that was since updated to 12.3.1 from 11.6.x to see this happen in all of it’s heart-crushing glory

fractalgee · April 17, 2022, 11:19am

Oh, one other note, after it does rearrange your 4 row patch, if that is in autosave (likely yes if autosave interval is at default), then it becomes a 2 row even more jumbled heap of mess. Not tried if subsequent start with that in autosave would make it a.one row never to be put into logical flow again patch, but that seems likely…

@Eurikon : Did 2.1.0 ever work fine on your M1 with 12.3.1 or did it take a week (or so) before this started? If it started a few days after OS update, what did change system-wise on your Mac since then? I know mine (and I am sure that was the only one) was XCode and command line tools update, after that Rack 2.1.0 was unusable visually speaking. 2,0,6 is fine with same updates…

Eurikon · April 17, 2022, 11:33am

I had this problem before Mac OS 12.3.1 and since 2.1 VCV

LarsBjerregaard · April 18, 2022, 9:49am

That sounds real… interesting. I wonder if @dlphillips or @synthi are seing the same?

synthi · April 18, 2022, 11:10am

I’m still on 11.6 I can’t see that behaviour

diimdeep · April 18, 2022, 2:00pm

I had this issue, coupled with new modules drag and drop rearrangement behaviour, it was too much… I decided to stay on 2.0 release for a while. Old habits die hard. (compiled from src, on macos 10.15.x)

fractalgee · April 18, 2022, 3:53pm

Just got a mail saying they are working on this, so guess must have found the issue, luckily. So here’s hoping it all gets sorted out soon.

pgatt · April 22, 2022, 9:09am

It’s not just on M1. I’ve now seen it and I don’t have an M1 Mac.

fractalgee · April 22, 2022, 9:15am

So what might have happened between it working fine and then all of the sudden starting to freak out? As stated, only updates prior to issue starting here was latest XCode and it’s comman line tools update… Nothing was recompiled or otherwise changed. So mystery abounds, guess you mean on Mac in general instead of M1 only?

pgatt · April 22, 2022, 9:39am

Yep that. Admittedly I saw it in a patch created on M1 I believe, but I saw it on a non-M1 Mac yes.

diimdeep · May 2, 2022, 6:34pm

Changing floor() to round() here fixes this problem. @Vortico

github.com

VCVRack/Rack/blob/v2/src/app/RackWidget.cpp#L643

      
        
            			return false;
            	}
            
            
	// Accept requested position
            	mw->setPosition(mwBox.pos);
            	updateExpanders();
            	return true;
            }
            
            
static math::Vec eachNearestGridPos(math::Vec pos, std::function<bool(math::Vec pos)> f) {
            	math::Vec leftPos = pos.div(RACK_GRID_SIZE).floor().mult(RACK_GRID_SIZE);
            	math::Vec rightPos = leftPos + math::Vec(RACK_GRID_WIDTH, 0);
            
            
	while (true) {
            		if (f(leftPos))
            			return leftPos;
            		leftPos.x -= RACK_GRID_WIDTH;
            
            
		if (f(rightPos))
            			return rightPos;
            		rightPos.x += RACK_GRID_WIDTH;

IMHO, this behaviour feels like too much smart from UX POV

github.com

VCVRack/Rack/blob/v2/src/app/RackWidget.cpp#L681-L708

      
        
            	// Check if new box occupies old box
            	if (!(newBox.pos.y == mw->box.pos.y && newBox.getLeft() <= mw->box.getRight() && newBox.getRight() >= mw->box.getLeft())) {
            		// Collect modules to the right of old pos
            		std::set<widget::Widget*, decltype(cmp)> rightOldModules(cmp);
            		for (widget::Widget* w2 : internal->moduleContainer->children) {
            			// Skip this module
            			if (w2 == mw)
            				continue;
            			// Modules must be on the same row as old pos
            			if (w2->box.getTop() != mw->box.getTop())
            				continue;
            			// Insert into rightOldModules
            			if (w2->box.getCenter().x >= mw->box.getCenter().x)
            				rightOldModules.insert(w2);
            		}
            
            
		// Shove old right modules to the left
            		float xRight = mw->box.getRight();
            		for (auto it = rightOldModules.begin(); it != rightOldModules.end(); it++) {
            			widget::Widget* w2 = *it;

This file has been truncated. show original

And I would like to have back old showe behaviour while holding RACK_MOD_CTRL

github.com

VCVRack/Rack/blob/v2.0.6/src/app/RackWidget.cpp#L753-L776

      
        
            	// Shove left modules
            	float xLimit = mw->box.pos.x;
            	for (auto it = leftModules.rbegin(); it != leftModules.rend(); it++) {
            		widget::Widget* w = *it;
            		math::Vec newPos = w->box.pos;
            		newPos.x = xLimit - w->box.size.x;
            		newPos.x = std::round(newPos.x / RACK_GRID_WIDTH) * RACK_GRID_WIDTH;
            		if (w->box.pos.x < newPos.x)
            			break;
            		w->setPosition(newPos);
            		xLimit = newPos.x;
            	}
            
            
	// Shove right modules
            	xLimit = mw->box.pos.x + mw->box.size.x;
            	for (auto it = rightModules.begin(); it != rightModules.end(); it++) {
            		widget::Widget* w = *it;
            		math::Vec newPos = w->box.pos;
            		newPos.x = xLimit;
            		newPos.x = std::round(newPos.x / RACK_GRID_WIDTH) * RACK_GRID_WIDTH;

This file has been truncated. show original

Eurikon · May 2, 2022, 7:06pm

ping @pgatt