Peaks clone ?

Steve_Russell · April 21, 2022, 3:23pm

A Forest Full of Sines:

The original code had:
		memset(&processors[0], 0, sizeof(processors[0]));
		memset(&processors[1], 0, sizeof(processors[1]));	
in the constructor. I was getting a warning about this, so I switched to peaks::Processors processors[2] = {}; where it is declared. This worked on Mac, but clearly not on Windows

No you were right to remove this code as processors isn’t a trivial type. So the line peaks::Processors processors[2] = {}; is correct.

I edited my crash log post as I initially thought it was a problem with the firmware; in reading the log I assumed (wrongly) that a large value was being passed by the module to the firmware. This is not the case. The problem is in the eurorack/peaks/modulations/multistage_envelope.cc file the trace is pointing to. This is due to the shape_ variable not being initialized in the void MultistageEnvelope::Init() method.

github.com

VCVRack/pichenettes-eurorack/blob/9739c0227708fab7a28b4efef7b27a9a1bc098d1/peaks/modulations/multistage_envelope.cc#L39-L47


      
          void MultistageEnvelope::Init() {
            set_adsr(0, 8192, 16384, 32767);
            segment_ = num_segments_;
            phase_ = 0;
            phase_increment_ = 0;
            start_value_ = 0;
            value_ = 0;
            hard_reset_ = false;
          }

The line pointed to in the crash is

github.com

VCVRack/pichenettes-eurorack/blob/9739c0227708fab7a28b4efef7b27a9a1bc098d1/peaks/modulations/multistage_envelope.cc#L81-L82


      
          uint16_t t = Interpolate824(
              lookup_table_table[LUT_ENV_LINEAR + shape_[segment_]], phase_);

which uses shape_ as an index for lookup_table_table

LUT_ENV_LINEAR is defined in eurorack/peaks/resources.h

segment_ and phase_ are initialized in void MultistageEnvelope::Init()

The fix I have used is to add this code to the end of void MultistageEnvelope::Init() in peaks/modulations/multistage_envelope.cc

for (uint8_t i = 0; i < 8; i++) {
    shape_[i] = {};
}

Any builders feel free to try the firmware code fix and let us know how you get on.