Looking good so far. Haven’t tried anything too complex, but digging Bernoulli especially. Update: May have encountered one issue with ST VCA not handling polyphonic signals with fx, where not voices are coming out when a polyphonic signal is connected to an FX. Without FX, it seems ok.
Hmmm… What do you mean by FX? Is it not working when you connect it to a specific module?
I can’t reproduce any problems when connecting it to a polyphonic module, so a sample patch would be helpful in determining what’s going on.
Going to try again tonight to see if I can reproduce it.
I’ve been running test a patch for a little while, generating simple stereo signals and running them through my polyphonic Werewolf distortion and the VCA seems to respond fine and as expected (mind you, it’s only 2 channels of polyphony…).
If you want the patch, let me know.
The Bernoulli gates seem to work fine, I tested them in a bigger trial patch.
Chroma overwrote my cable colors in settings.json… not a fan, I’m glad I have a backup.
Meta performs as advertised: cable plugging and unplugging sounds, didn’t try it with polyphonic signals…
Median also did what I expected it to do, but, again, didn’t try it with poly signals.
Ah, Chroma was made before the updates to cable colour customization from VCV 2.5.0 made it more usable, I’ll have to see how I can deal with that while preserving the existing functionality…
Apologies for any issues caused by that.
No worries, as I said, I have a backup
I’ve pushed a commit to make Chroma not mess with VCV’s cable colours settings, and a fix for a race condition in Meta that could rarely cause it to not trigger a sound.
I did not experience the Meta issue; but I can confirm Chroma left my colors alone. Thanks
@phantombeta Is there a reason that the META and ST-VCA modules have the titles right-justified, whereas the others have it nicely centered?
I do it based on how it looks. For the smaller modules like META and ST-VCA IMO when the title is centered it ends up looking kinda wonky and off-center, because of the top screw…
I supposed an idea would be to try centering the title between the screw and the right edge, but I feel that might look even wonkier, and it’d definitely look wonky with the wider modules
The Meta issue was rather rare, I thought I had noticed it happen during development once or twice, but could never confirm it.
I only noticed it existed for sure when I found out you can unlock the UI framerate while looking through VCV’s code, when the framerate was unlocked, it’d show up far more often. (I was exchanging an atomic<bool>
in the UI code that triggers the sounds playing when I meant to only set it)
I’ve pushed a couple of new changes related to Chroma. I made a tweak that hopefully ensures it always updates the colour of new cables immediately instead of lagging by one frame, and I fixed duplicated cables being recoloured after the previous update’s changes. (It can only detect Ctrl+Shift+Drag, unfortunately, but this is the best I could do)
simple solution - don’t put any screws on the panel.
I’ve fixed Chroma not colouring cables when the duplicate key combo (Ctrl + Shift) was used without any existing cables to duplicate on that port.
I’ve also added support for sounds when placing and removing modules, but since I don’t have any sounds for it yet, I’ve left it in a separate branch for now.