Experiencing weird rearrangement issues with modules in patch

LarsBjerregaard · April 18, 2022, 9:49am

That sounds real… interesting. I wonder if @dlphillips or @synthi are seing the same?

synthi · April 18, 2022, 11:10am

I’m still on 11.6 I can’t see that behaviour

diimdeep · April 18, 2022, 2:00pm

I had this issue, coupled with new modules drag and drop rearrangement behaviour, it was too much… I decided to stay on 2.0 release for a while. Old habits die hard. (compiled from src, on macos 10.15.x)

fractalgee · April 18, 2022, 3:53pm

Just got a mail saying they are working on this, so guess must have found the issue, luckily. So here’s hoping it all gets sorted out soon.

pgatt · April 22, 2022, 9:09am

It’s not just on M1. I’ve now seen it and I don’t have an M1 Mac.

fractalgee · April 22, 2022, 9:15am

So what might have happened between it working fine and then all of the sudden starting to freak out? As stated, only updates prior to issue starting here was latest XCode and it’s comman line tools update… Nothing was recompiled or otherwise changed. So mystery abounds, guess you mean on Mac in general instead of M1 only?

pgatt · April 22, 2022, 9:39am

Yep that. Admittedly I saw it in a patch created on M1 I believe, but I saw it on a non-M1 Mac yes.

diimdeep · May 2, 2022, 6:34pm

Changing floor() to round() here fixes this problem. @Vortico

github.com

VCVRack/Rack/blob/v2/src/app/RackWidget.cpp#L643

      
        
            			return false;
            	}
            
            
	// Accept requested position
            	mw->setPosition(mwBox.pos);
            	updateExpanders();
            	return true;
            }
            
            
static math::Vec eachNearestGridPos(math::Vec pos, std::function<bool(math::Vec pos)> f) {
            	math::Vec leftPos = pos.div(RACK_GRID_SIZE).floor().mult(RACK_GRID_SIZE);
            	math::Vec rightPos = leftPos + math::Vec(RACK_GRID_WIDTH, 0);
            
            
	while (true) {
            		if (f(leftPos))
            			return leftPos;
            		leftPos.x -= RACK_GRID_WIDTH;
            
            
		if (f(rightPos))
            			return rightPos;
            		rightPos.x += RACK_GRID_WIDTH;

IMHO, this behaviour feels like too much smart from UX POV

github.com

VCVRack/Rack/blob/v2/src/app/RackWidget.cpp#L681-L708

      
        
            	// Check if new box occupies old box
            	if (!(newBox.pos.y == mw->box.pos.y && newBox.getLeft() <= mw->box.getRight() && newBox.getRight() >= mw->box.getLeft())) {
            		// Collect modules to the right of old pos
            		std::set<widget::Widget*, decltype(cmp)> rightOldModules(cmp);
            		for (widget::Widget* w2 : internal->moduleContainer->children) {
            			// Skip this module
            			if (w2 == mw)
            				continue;
            			// Modules must be on the same row as old pos
            			if (w2->box.getTop() != mw->box.getTop())
            				continue;
            			// Insert into rightOldModules
            			if (w2->box.getCenter().x >= mw->box.getCenter().x)
            				rightOldModules.insert(w2);
            		}
            
            
		// Shove old right modules to the left
            		float xRight = mw->box.getRight();
            		for (auto it = rightOldModules.begin(); it != rightOldModules.end(); it++) {
            			widget::Widget* w2 = *it;

This file has been truncated. show original

And I would like to have back old showe behaviour while holding RACK_MOD_CTRL

github.com

VCVRack/Rack/blob/v2.0.6/src/app/RackWidget.cpp#L753-L776

      
        
            	// Shove left modules
            	float xLimit = mw->box.pos.x;
            	for (auto it = leftModules.rbegin(); it != leftModules.rend(); it++) {
            		widget::Widget* w = *it;
            		math::Vec newPos = w->box.pos;
            		newPos.x = xLimit - w->box.size.x;
            		newPos.x = std::round(newPos.x / RACK_GRID_WIDTH) * RACK_GRID_WIDTH;
            		if (w->box.pos.x < newPos.x)
            			break;
            		w->setPosition(newPos);
            		xLimit = newPos.x;
            	}
            
            
	// Shove right modules
            	xLimit = mw->box.pos.x + mw->box.size.x;
            	for (auto it = rightModules.begin(); it != rightModules.end(); it++) {
            		widget::Widget* w = *it;
            		math::Vec newPos = w->box.pos;
            		newPos.x = xLimit;
            		newPos.x = std::round(newPos.x / RACK_GRID_WIDTH) * RACK_GRID_WIDTH;

This file has been truncated. show original

Eurikon · May 2, 2022, 7:06pm

ping @pgatt