Merge my PR that fixes the segmentation fault on exit if someone uses one of the blanks in a patch.
Make a post here Chiptuner · Issue #591 · VCVRack/library · GitHub that the plugin is now ready to be updated and added to the library - make sure to repond to any feedback.
The segfault also happens when just opening the module browser.
I only got a segfault on exit. My PR was only tested on WIndows.
Sorry, clarification: you don’t need to ADD a module for Rack to crash on exit. You just have to open the module browser and it will crash on exit.
That looks like the ModuleWidget’s pointer to the underlying Module is not initialized properly.
I did that. I hope I did it right, tho…
If you go back some posts, you’ll see a GDB log. Would you agree with Paul’s assessment in his post that follows?
ok, so I gave it a try. Commenting out line 20 in Bitmap.cpp seems to help here. I think, the destructor on line 19-21 in Bitmap.hpp is not needed, same goes for the destructor on line 37-40 in Bitmap.hpp
but generally it is not a good idea to load an image like it is done on line 6 in Bitmap.hpp, instead use APP->window->loadImage()
https://vcvrack.com/docs-v2/structrack_1_1window_1_1Window#a605341c15fc66cbeb8e294363c404fe5
additionally keep in mind what the migration manual says about fonts and images:
as I said in my first post here, porting this module sounds interesting to me, but I would definitely not take over ownership
December 15 2021, I wanted to submit a panel plugin to the library.
I got this response (didn’t keep the email), and the module was not added to the library:
“… we generally don’t accept panel-only plugins anymore unless they offer some kind of visual signal manipulation.”
It seems to me “weird”, just not to say something worst. How they justify then the blank panels that do nothing like Bogaudio, Mochba, Impromptu, AS, CF, Stellare, VCV itself, Quanta, Geodesic, wiqid, Submarine, JW and the many others that do not offer any visual manipulation and are present in the library?
As I mentioned earlier, it’s alright. At this point I won’t “force” anyone to take the ownership. I will put your name in the credit as the volunteer that migrated the modules to the new release. That’s why I changed the name of the whole thread… 
Each of those collections have modules which are more than just blank panels. I think jens’ experience was with a blank panel only collection. I have not looked at your plugins to know if they are such a thing or not.
I totally don’t know if this can help: at the time I was trying to use SVG pictures to use for the modules but then I discovered that bitmmaps pictures worked just as fine, witht the only drawback that when zooming too much in VCV there was some quality loss. At the time I thought it was no big deal, the plugin worked and so I left the bitmap also because I tried to convert those picture into vector picture with Inkscape but it turned out to be an enormous hassle, I never get what I wanted and all the result were less than acceptable.
Oh, I understand. Yes, mine are just blank panels. I don’t have enough expertise to do more than that (and even doing those panels was quite hard for me, as you can guess from this thread! LOL!) Nevertheless those words are a tad misleading, IMAO. 
I think the confusion may arise from the nomenclature. A “plug-in” is the entire collection of modules in a single package. So for instance the surge xt “plug-in” has 40 modules.
So a panel only plug-in is not a module with just a blank panel. It is an entire set of modules where none of them are anything other than blank.
I was confused by this all the way back at rack 0.5 when I wanted to name the original “BaconMusic” as “BaconPlugs” since I thought of each module as a plug-in - a vst/au bias which is semantically a bit misleading in rack land. Andrew told me that plugs plural was the wrong name and then it clicked. The single dll/plug-in.json combo is a “plug-in”
Since then protocols like clap and vst3 have allowed multiple plugins in a single software asset. So that’s even more confusing since a clap plug-in might actually provide 4 synths and an effect!
So anyway it’s all a bit confusing. But in rack land plug-in = collection of modules with a json file and a DLL. Hope that helps!
Thanks for taking a look. This is what my PR does, in that it removed both destructors in Bitmap.hpp which worked because of the use of smart pointers; so at least I know from the log I was looking in the right place.
Ok, thank you for the clarification. But now what am I supposed to do? Because if they will reject my plugin (as you intended) I have an idea to ask to mscHack if I (or more likely some good will voluntary) can include in my panels the following modules that I used to use A TON!
So that CHIPTUNE won’t be only a blank panel plugin but will have something usable to make noises. DO you think could be a decent idea?
Hello again,
sorry but… Seriously, what should I do now??? Please don’t assume I know how github works. I got lucky so far. 
You wait.
I think the the way it loads bitmaps was fine when I wrote it back in vcvrack 0.6. But the API added better support in v1. and I doubt that any of my custom bitmap classes are really necessary any more.
Certainly I would expect issues with the module browser, because that wasn’t a thing back in those days.