Porting Valley plugins to v2

You raise a good point and I’m interested what the ‘rules’ around this are for software that is open source.

I guess from a legal perspective, anyone can fork and modify an open source repo without explicit permission from the developer as long as they honour the license.

But morally it seems right to contact the developer first.

3 Likes

Okay, I’ll wait for developer contact. Thanks guys.

2 Likes

It’s a courtesy to contact the developer. It can demonstrate some appreciation for the previous work that was done.

Practically, it’s likely the developer has the most intimate knowledge of the code. They might already be in the process of migration. There might be issues they are aware of. They might just need a little time to get things done.

Or they might have some advice that would help anyone attempting the migration.

Or maybe they just can’t, or don’t want to, spend time on it right now.

But contacting them is the first thing I try.

5 Likes

Oh, and for anyone trying my naive branch above, of course it’s not stable. As I wait for contact with the developer, I may tinker and try to understand why it crashes, and improve things, but I am NOT the developer, and am just learning how all of this is put together.

@valley.audio wrote a PhD thesis on Reverberation, hence Plateau’s following. Wait for him please, as he is considering porting them already

4 Likes

Will do, I’ll remove my fork, as it’s more of a kindergarten attempt. Not worthy.

But kudos to you for stepping up and giving it a whirl.

1 Like

I think it’s his PhD thesis, but who’s counting :stuck_out_tongue:

http://eprints.hud.ac.uk/id/eprint/35045/

3 Likes

so right you are, corrected… :blush:

2 Likes

Hello all,

I thought I’d chime in and update you where I am up to with my plugins for Rack and v2.

Development has slowed greatly lately due to other commitments, general burnout from programming for a living as well as due to the “unique” time we have all experienced this past year and a half (it has definitely caused a lot stress in my personal life, but I know I am not alone in that situation).

This isn’t to say I have abandoned my plugins, far from it actually. It is nice to see people anxious to see them ported to v2 and having a go at compiling them. I am actually in the process of porting to v2, though it will take a small amount of time due to (again) other commitments taking a higher priority.

Anyway, I hope everyone is well :slight_smile:

Cheers! Dale

44 Likes

Okay, Valley is working on v2, albeit not fully tested and the graphics are “outdated”. I have not had chance to make a release version for you to simply download, so you will have to clone and build this repo for now.

16 Likes

Legend! Thanks!

PSA everyone! It’s okay, you can use Rack 2 now. Plateau is back! :stuck_out_tongue:

6 Likes

Best. Reverb. Ever!

1 Like

Excellent! My v1 template almost loads in v2 now without much missing (still Chronoblob and a few bits and bobs missing), but the bulk is now functional on v2! Good times! And yes, ‘Best. Reverb. Ever!’ indeed!

Thanks for the v2 version. And thanks for this fix: Correct output saturation and clipping in Plateau · ValleyAudio/ValleyRackFree@4605991 · GitHub

To think (if reading repo history correctly) that bug has been around for 5 months…

And the module still sounds amazing; that’s how really good it is.

1 Like

Thanks for making this available!

Has prompted me to try building plugins for the first time.

Anyone got any pointers on why I’m getting: fatal error: ‘window.hpp’ file not found

when trying to make on Mac (10.14.6)?

Ah, I see I was missing there is a compiled release already. Sorry for adding to the noise!

I think to say that people will be happy to hear this is being worked on would be a massive understatement. Plateau must be one of the (if not the) most widely used modules in the entire library.

2 Likes

plateau is one of the best reasons to use rack. its no joke the best reverb ever made.

Make sure you checkout branch v2.0, I haven’t set the default to v2.0 yet. I caught myself out with that this morning when rebuilding my modules on a new machine :upside_down_face:

2 Likes