…it’s not a good idea to propose (like the real hardware does) up to 32 user waveforms… 
Really, who need 32 user waveforms?
Of course I’m nearly sure they’re no event handler when saving as preset, like onPresetSave().
No, preset saving uses the same path as patch saving. But nothing prevents you from writing your own, which augments dataToJson() with some additional fields.
About the user waveforms: maybe it makes more sense to store them as plugin settings instead of per module instance. So 32 user waveforms, which are shared.
Yep I’ve considered this possibility, as shared instead per plugin instance !
EDIT: cancelled! unfortunately I can’t consider “32 shared” waveforms, because on using shared patch(es) or by using another patch(es), they’re possible conflicts between different waveforms but on the same “slot” (in this scenario, previous waveform(s) is/are lost and replaced by the new ones).
By this way, I’ve kept the Save waveforms with “Preset” toggle in context menu. Also, I’ve added a large red LED at the bottom of module, will fast blink (8 times per second!) to warn the user in case he’d like to create a preset, if at least 4 user waveforms are already loaded AND if the option is unchecked from the context menu.
The large LED:
4 user waveforms (or less) are always serialized in json (Preset warning LED stays unlit).
Perhaps I’ll must consider a loseless compression format, like FLAC, in order to be serialized with less data volume in json file…
Hello,
Definitely bad news, the user waveforms will not be embedded in json by using “Save waveforms with presets”, as suggested by Ben (stoermelder - thanks anyway to him), it’s not reliable! Sometimes (it’s random) from dataFromJson() method, some waveform(s) are missing! Definitively I hate json!!!
By this way, VCV presets can’t embed waveforms (as long as a patch storage isn’t implemented in VCV Rack’s API for presets who are using important amount of datas, or a way to differentiate a regular patch file/autosave vs. a preset file).
Saving only 4 user waveforms (as uncompressed PCM) reaches the 100 kilobytes limit for json serialization, as indicated in VCV Rack manual.
I was go back, I’ve removed the large LED concept (at the bottom of module) as I described in previous post. The idea was good (IMHO), but not viable.
User waveform files are handled by onSave() / onAdd() methods only.
Too bad!
Hello!
Today they’re good news (to change from the bad ones, recently 
):
- FM is implemented, choice from TZFM (aka Linear Through-Zero FM, as default “FM“ setting), or Phase Modulation (PM), using FM input jack (input signal must fit into -5V/+5V range, otherwise it will be clipped). FM settings is always per program.
- Two independent LFOs (LFO 1, LFO2), frequency range 0.01Hz to 50Hz (0.01 stepping), default 2Hz, common (bipolar -5V/+5V) waveforms (SINE, TRIANGLE, SAWTOOTH, RAMP, SQUARE and RANDOM), AMP amount (amplitude of the modulation) from 0% (0% assumes the relevant LFO is turned off, it’s the default setting for LFO 2 only) to 100%. RETRIGGER may be off (free) or by incoming gate voltage (on GATE input jack) to restart LFO 1 and/or LFO 2 phases (depending their respective settings).
- On factory default (new module, of after Initialize from right click menu), LFO 1 is always “open” as AMP 100%, SINE, 2Hz, no retrigger. LFO 2 is always “closed” (AMP 0%), but other settings are strictly identical.
- Like FM mode (and its FM DEPTH from 0% - aka FM OFF, up to +100%), LFO 1 and LFO 2 are program-dependent, too.
- FM LED near input jack is solid green when connected, and FM DEPTH parameter is greater than 0% .
Program is like a synthesizer preset.
Each oscillator (A, B, C, D) can be modulated by FM input (TZFM or PM), or by any LFO (1 or 2).
This is the final version of VX expander, now it can output both LFO 1 and LFO 2 “curves” (always into -5V/+5V voltage range).
Following example, OSC A is modulated by LFO 1:
…but can be modulated by LFO 2, or by FM input jack (TZFM or PM, depending the FM setting from 3rd page of PROGRAM), or… not modulated. 
.
By default, each oscillator’s MOD. SOURCE is set to NONE (not modulated).
3 Likes
Few development today, but the Vektor User’s Manual is under construction:
https://github.com/DomiKamu/OhmerPrems/blob/v2/docs/modules/Vektor/Manual.md
Unlike FranKe, I’d like to provide a full (completed) user’s manual for this future module!